Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download progress bar does not print correct LT version #88

Open
ybracke opened this issue Apr 18, 2024 · 0 comments
Open

Download progress bar does not print correct LT version #88

ybracke opened this issue Apr 18, 2024 · 0 comments

Comments

@ybracke
Copy link

ybracke commented Apr 18, 2024

The download progress bar that is invoked in this line will always say 'Downloading LanguageTool 6.4', regardless of which version the program actually downloads.

What I did:
LanguageTool(language_tool_download_version='6.3'

Expected behavior:

  1. Download LanguageTool-6.3 to ~./cache/language_tool_python
  2. Print Downloading LanguageTool 6.3 to stdout in front of the progress bar.

Actual behavior:

  1. Download LanguageTool-6.3 to ~./cache/language_tool_python
  2. Print Downloading LanguageTool 6.4 to stdout in front of the progress bar.

Possible solutions:
In get_http, get the version from url and not from the static LTP_DOWNLOAD_VERSION. Or, pass the variable version from download_lt to download_zip to get_http.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant