Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔍 check support for polars #14

Open
jvdd opened this issue Jan 12, 2023 · 2 comments
Open

🔍 check support for polars #14

jvdd opened this issue Jan 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jvdd
Copy link
Owner

jvdd commented Jan 12, 2023

Might be interesting to extend the ArgMinMax trait for polars as well!

(no idea if this is feasible, or if this even makes sense) => needs first some more research 🕵️

@jvdd jvdd added the enhancement New feature or request label Jan 12, 2023
@ritchie46
Copy link

Hi @jvdd If you implement the PrimitiveArray of arrow2, you will have most of polars support done.

https://github.com/jorgecarleitao/arrow2

@jvdd
Copy link
Owner Author

jvdd commented Apr 4, 2023

@ritchie46, #48 adds support for arrow2 :)

Not really sure if anything else should be done?

The only thing I can think of is adding support for arrow its validty bitmap 🤔 - currently, this aspect of arrow is ignored (which happens in polars as well?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants