Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting unexpectedly stopped working after commenting a chunk of code #16321

Open
aakhmetz opened this issue May 13, 2024 · 1 comment

Comments

@aakhmetz
Copy link

When I have a code:
image
and commented the selected chunk of code, the other part of already commented lines became not highlighted:
image

I wonder why

@aakhmetz aakhmetz added the bug label May 13, 2024
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label May 13, 2024
@JasonWeill JasonWeill changed the title The code highlight unexpectedly stopped working after commenting a chunk of code Syntax highlighting unexpectedly stopped working after commenting a chunk of code May 14, 2024
@JasonWeill JasonWeill added pkg:codemirror and removed status:Needs Triage Applied to new issues that need triage labels May 14, 2024
@JasonWeill
Copy link
Contributor

@aakhmetz Thanks for opening this issue! I see that the code at the bottom of your screenshot doesn't have the same green italic look as it did before. Which version of JupyterLab are you running?

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue May 17, 2024
…#16234)

* Update browser.json

Adjusted wording to satisfy issue jupyterlab#16321

Use "Folder", not "Directory", in file browser settings jupyterlab#16231

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue jupyterlab#16025

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue jupyterlab#16025

* Delete Untitled.ipynb

* Delete Untitled1.ipynb

* Updating Docs

Changed all instances of 'directory' to 'folder' to start.

Reviewing videos for those which need to be updated to reflect the changes made for this issue.

* Updating 'directory' to 'folder'

* Updating 'directory' to 'folder'

* Adjusting 'directory' to 'folder' when referencing locations inside jupyterlab but not local file structures.

* Removing start.sh from gitignore

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update Playwright Snapshots

* Update Playwright Snapshots

* Revert unrelated changes

* Revert snapshot changes and docker/start.sh change

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue May 17, 2024
…6237)

* Update browser.json

Adjusted wording to satisfy issue jupyterlab#16321

Use "Folder", not "Directory", in file browser settings jupyterlab#16231

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue jupyterlab#16025

* -Removed elipses from:
 File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue jupyterlab#16025

* Delete Untitled.ipynb

* Delete Untitled1.ipynb

* Update Playwright Snapshots

* Update Playwright Snapshots

* Corrections Applied per JasonWeill's feedback.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update Playwright Snapshots

* Update Playwright Snapshots

* Revert unrelated changes

* Fix test

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants