Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift + tab does not open inspector tooltip on 4.2.0 #16319

Closed
krassowski opened this issue May 11, 2024 · 1 comment · Fixed by #16343
Closed

Shift + tab does not open inspector tooltip on 4.2.0 #16319

krassowski opened this issue May 11, 2024 · 1 comment · Fixed by #16343
Labels
bug pkg:inspector pkg:tooltip tag:Regression Behavior that had been broken, was fixed, and is broken again
Milestone
4.2.x

Comments

@krassowski
Copy link
Member

Description

Shift + tab does not open inspector tooltip on 4.2.0

as reported on https://stackoverflow.com/questions/78464382/shift-tab-isnt-showing-docstring-anymore

Reproduce

  1. Type int
  2. Press Shift + Tab

Expected behavior

  • There is an integration test case for this shortcut
  • The shortcut works

Context
@krassowski krassowski added bug pkg:tooltip status:Needs Triage Applied to new issues that need triage tag:Regression Behavior that had been broken, was fixed, and is broken again pkg:inspector labels May 11, 2024
@krassowski krassowski added this to the 4.2.x milestone May 11, 2024
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label May 14, 2024
@JasonWeill JasonWeill mentioned this issue May 14, 2024
Open
@krassowski
Copy link
Member Author

krassowski commented May 18, 2024 •
edited

So this looks to be another side-effect of jupyterlab/lumino#662 but in this case it seems to be because dedentIfNotLaunchingTooltip returns true on Shift + Tab:

Screenshot from 2024-05-18 19-17-37

@krassowski krassowski mentioned this issue May 18, 2024
Merged
2 tasks
@krassowski krassowski mentioned this issue May 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pkg:inspector pkg:tooltip tag:Regression Behavior that had been broken, was fixed, and is broken again
Projects
None yet
Milestone
4.2.x
Development

Successfully merging a pull request may close this issue.

Fix Shift + Tab contextual help inspector tooltip regression krassowski/jupyterlab
2 participants
@krassowski @JasonWeill