Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterHub Services url isn't always suitable for a health check - add a service property or not? #4637

Open
consideRatio opened this issue Nov 17, 2023 · 1 comment

Comments

@consideRatio
Copy link
Member

By configuring JupyterHub service's url to http://my-service-backend, users can visit https://my-jupyterhub.org/services/my-service to reach it. Sometimes this service have a dedicated path to make health checks, such as http://my-service-backend/api/health, but JupyterHub will check its health by default to the configured url that is also used to configure the /services/my-service proxied path. A single url is used for multiple purposes and that isn't great.

A minor issue has occurred for dask-gateway that needs to have a /services/dask-gateway path configured for users to access URLs like /services/dask-gateway/dashboards/..., but at the same time expects health checks to go to http://dask-gateway/api/health.

Would it be a good call to help handle these situations by one of the ideas below?

  • To let JupyterHub accept an additional field to a service's configuration to specify the desired health check endpoint, separate from url if specified.
  • To let JupyterHub accept an additional field to a service's configuration to opt out of having a health check against url.

Related

@consideRatio consideRatio changed the title JupyterHub Services url isn't always suitable for a health check JupyterHub Services url isn't always suitable for a health check - add a service property or not? Nov 17, 2023
@minrk
Copy link
Member

minrk commented Nov 17, 2023

I think both service.health_check_url (relative to service prefix) and service.disable_health_check make perfect sense to add as service config options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants