Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move button to switch from JupyterLab to Notebook #7004

Open
lahwaacz opened this issue Aug 9, 2023 · 2 comments · May be fixed by #7113
Open

Move button to switch from JupyterLab to Notebook #7004

lahwaacz opened this issue Aug 9, 2023 · 2 comments · May be fixed by #7113
Labels
enhancement

Comments

@lahwaacz
Copy link

lahwaacz commented Aug 9, 2023

As shown in jupyter/jupyter#420 (comment), the button Launch Jupyter Notebook File Browser is located in the Help menu in JupyterLab. On the other hand, Jupyter Notebook 7 has an Open JupyterLab button in the View menu. I would like to suggest moving Launch Jupyter Notebook File Browser from Help to View for consistency.
@lahwaacz lahwaacz added enhancement status:Needs Triage Applied to issues that need triage labels Aug 9, 2023
@lahwaacz lahwaacz mentioned this issue Aug 9, 2023
Closed
@jtpio
Copy link
Member

jtpio commented Aug 9, 2023 •
edited

Thanks @lahwaacz for opening the issue.

This is where the menu entry is defined:

notebook/packages/lab-extension/schema/launch-tree.json

Lines 7 to 12 in b5133c6

"id": "jp-mainmenu-help",
"items": [
{
"command": "jupyter-notebook:launch-tree",
"rank": 1
}

To put it under View we would need to update to the following:

"id": "jp-mainmenu-view"

For reference here is the PR that added the menu entry to RetroLab (the ancestor of Notebook 7): jupyterlab/retrolab#138

@jtpio jtpio removed the status:Needs Triage Applied to issues that need triage label Aug 9, 2023
@jayeshsingh9767
Copy link
Contributor

jayeshsingh9767 commented Oct 18, 2023 •
edited

@jtpio could u please assign this to me, will like to take this up.

@jayeshsingh9767 jayeshsingh9767 linked a pull request Oct 18, 2023 that will close this issue
Open
@joaovml joaovml mentioned this issue Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrated launch-tree from Help Menu Option to View jayeshsingh9767/notebook
3 participants
@jtpio @lahwaacz @jayeshsingh9767