Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 1.1.0 release? #678

Open
jtpio opened this issue Apr 3, 2023 · 12 comments
Open

New 1.1.0 release? #678

jtpio opened this issue Apr 3, 2023 · 12 comments

Comments

@jtpio
Copy link
Member

jtpio commented Apr 3, 2023

JupyterLab was added to the metapackage in #615

But currently the latest release on PyPI is still 1.0.0, without the jupyterlab dependency: https://pypi.org/project/jupyter

image

With #628 it looks like it should now be possible to make releases from CI.

So maybe we should consider making a 1.1.0 release soon? Or even 2.0.0.

This would be relevant for the upcoming JupyterLab 4 / Notebook 7 releases, expected before JupyterCon early May 2023.

@jtpio
Copy link
Member Author

jtpio commented Apr 3, 2023

For reference the jupyter metapackage seems to be quite popular:

image

https://pepy.tech/project/jupyter

@jtpio
Copy link
Member Author

jtpio commented Apr 6, 2023

cc @minrk @choldgraf since you both worked on #628.

What would it take to make a new release of the jupyter metapackage, so it includes jupyterlab added in #615?

Thanks for your help!

@choldgraf
Copy link
Collaborator

I'm not really sure unfortunately, I've never made a release of this and mostly am just doing whatever I can to help things move forward. If there is some action that I can help unblock please let me know.

@jtpio
Copy link
Member Author

jtpio commented Apr 6, 2023

yeah I am not sure either. It's also not clear which Jupyter subproject owns this repository and the jupyter name on PyPI.

@choldgraf
Copy link
Collaborator

you seem to be one of the maintainers on pypi?

image

that's from: https://pypi.org/project/jupyter/

@jtpio
Copy link
Member Author

jtpio commented Apr 6, 2023

Yes but I don't have commit rights on this repo (https://github.com/jupyter/jupyter). Which are usually necessary to push a new tag and probably also using the GitHub Action workflow mentioned above.

@choldgraf
Copy link
Collaborator

choldgraf commented Apr 6, 2023

Ahhh I see - I think in that case you definitely should have commit rights if you are a maintainer on PyPI. I don't have them though ever since I was removed as an "owner status" from the jupyter/ org. Maybe @jasongrout has them?

@jasongrout
Copy link
Member

Good catch finding this repo isn't clearly owned by a subproject or council.

Since this is definitely an issue that impacts multiple subprojects, I'd suggest taking it up with @jupyter/software-steering-council. Perhaps they should own this repo, or the Jupyter Foundations subproject?

@jtpio
Copy link
Member Author

jtpio commented Apr 7, 2023

So what should the process be? Continue the conversation here with @jupyter/software-steering-council, or open a new issue somewhere else?

@JohanMabille
Copy link
Member

JohanMabille commented Apr 7, 2023

I think it makes sense to have this repo owned by the SSC and to give commit rights to the PyPI maintainers.

Edit: I don't have commit rights on this repo btw.

@choldgraf
Copy link
Collaborator

My 2 cents: I'd recommend that the SSC or the Foundations group is responsible for the mandate and principles that guide how this repo evolves. But in terms of merge rights and day to day, I suggest we liberally give those rights to those with standing in any of the jupyter subprojects, under the assumption that they'll act in good faith within the principles defined by the SSC. To start, I think anybody with pypi access should have commit access.

@minrk
Copy link
Member

minrk commented Apr 7, 2023

@jtpio i added you to the repo

This was referenced Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants