Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for id_token_signing_alg_values_supported #411

Open
timoschinkel opened this issue Mar 14, 2024 · 1 comment
Open

Support for id_token_signing_alg_values_supported #411

timoschinkel opened this issue Mar 14, 2024 · 1 comment

Comments

@timoschinkel
Copy link

It is good practice to specify what JWT signature algorithms are allowed: https://curity.io/resources/learn/jwt-best-practices/#10-how-to-work-with-the-signature

Within the OpenID Connect autodiscovery document there is a property called id_token_signing_alg_values_supported that contains a list of allowed signature algorithms for the tokens: https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata

Currently this library does not check this value when validating the signature in \Jumbojett\OpenIDConnectClient::verifyJWTsignature(). Is that deliberate? If not; are you open to introduce support for this? I'm willing to try and create a pull request, but not if you don't plan to support this anyway :)

@timoschinkel
Copy link
Author

Looking at the other issues, this might be a duplicate of #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant