Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Jumbojett\OpenIDConnectClient::$leeway is not overrideable #379

Open
timoschinkel opened this issue Jul 4, 2023 · 0 comments
Open

\Jumbojett\OpenIDConnectClient::$leeway is not overrideable #379

timoschinkel opened this issue Jul 4, 2023 · 0 comments

Comments

@timoschinkel
Copy link

The value for \Jumbojett\OpenIDConnectClient::$leeway is fixated to 300 seconds. Although exposed outwards using \Jumbojett\OpenIDConnectClient::getLeeway() there is no way to manipulate the value for leeway.

Is this deliberate? We are in control of all of our servers and we are interested in lowering the leeway. I think that there are three ways to do this without too much changes codewise:

  1. Make \Jumbojett\OpenIDConnectClient::$leeway protected
  2. Introduce a public or protected \Jumbojett\OpenIDConnectClient::setLeeway() method
  3. Use \Jumbojett\OpenIDConnectClient::getLeeway() internally

So my questions:

  • Are you open to allow adjusting the leeway?
  • If so, do you prefer one of the proposed solutions?
  • If so, do you want me to create a pull request for this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant