Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$ Not defined #592

Open
hebronwatson opened this issue Sep 16, 2021 · 3 comments
Open

$ Not defined #592

hebronwatson opened this issue Sep 16, 2021 · 3 comments

Comments

@hebronwatson
Copy link

hebronwatson commented Sep 16, 2021

Summary

The timeseries in the Dockercoins Web App is non-functional

Probable Cause

Firefox does not recognize the contents of the jquery.js file as a symlink, and trying (unsuccessfully) to parse the contents (simply, jquery-1.11.3.min.js) as JavaScript.

Environment

Docker for Desktop on Windows 10

@jpetazzo
Copy link
Owner

Hi, thanks for this bug report!

If you edit index.html to update the link (putting jquery-1.11.3.min.js instead of jquery.js), does it fix the problem?

Thank you!

@hebronwatson
Copy link
Author

Wow! THE JPetazzo is responding to my issue? Ok!

Yeah, it totally fixes it, but I was wondering why it's in there in the first place? Is it supposed to be a type of symlink, and if so, why does it not work? It really shouldn't be my environment that's the problem, right?

@jpetazzo
Copy link
Owner

jpetazzo commented Oct 4, 2021

Hi!

I think I made this to be able to easily change the version of jquery by updating a symlink, instead of updating the HTML code.
When I wrote the app, I thought I might end up with multiple HTML pages, so I wanted to be able to switch dependencies in a single place.
I'm not 100% sure though, because I wrote this thing 6 years ago and I had never needed to look again at that particular piece of the code 😅

That said, I tried to reproduce the bug on my Windows 10 machine, and ... it worked fine 🤔
On my machine, the jquery.js symlink shows up as <JUNCTION> when I run dir.
Out of curiosity, what does it look like on your machine?
And are you using WSL2? (No idea if it matters or not, but I'm using it, because this is a Windows 10 Home machine.)

Either way, I think I'll edit the index.html file after all; but I really wonder what's going on there :)

jpetazzo added a commit that referenced this issue Oct 4, 2021
On some Windows 10 installs, the jquery.js link doesn't work
properly (see #592). So I'm removing that symlink and linking
directly to jquery-1.11.3.min.js from the HTML page.

Thanks @hebronwatson for reporting this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants