Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Folia support #56

Open
sofianedjerbi opened this issue Apr 2, 2023 · 3 comments
Open

[Feature Request] Folia support #56

sofianedjerbi opened this issue Apr 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@sofianedjerbi
Copy link

It would be great to have folia support.
I'm going to create a PR, so here is a little Feature Request.

@sofianedjerbi sofianedjerbi added the enhancement New feature or request label Apr 2, 2023
@jpenilla
Copy link
Owner

jpenilla commented Apr 2, 2023

With a regionized server, global MSPT/TPS doesn't make sense as a concept.

Displaying information for all regions in the displays would be cluttered to the point where it becomes useless.

The best I think we could sensibly do is display information for the player's current region. If anyone has a proposal for something more extensive, feel free to share, but if it's too cluttered it won't be accepted.

Anyways, there's a lot more to monitor with Folia than with Paper or other supported platforms, and if you have a use case where Folia makes sense, you should probably be using something like UnifiedMetrics anyways.

@sofianedjerbi
Copy link
Author

sofianedjerbi commented Apr 2, 2023

I was going to add/change the following modules:

tps: Current region TPS
mean_tps: Mean TPS on Folia
median_tps: Median TPS on folia

Same with MSPT

@jpenilla
Copy link
Owner

jpenilla commented Apr 2, 2023

I would prefer naming like
current_region_tps
regions_mean_tps
and etc. Would probably want min and max too.

As for the existing tps and mspt modules, I think we should just have them delegate to the current_region equivalent when running on Folia.

Another thing is the tick info command should not be registered on Folia. Folia's built-in command is good enough that we don't need to waste effort implementing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants