Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account Minecraft version for update checks on Fabric #30

Open
Lentern opened this issue Dec 5, 2021 · 2 comments
Open

Take into account Minecraft version for update checks on Fabric #30

Lentern opened this issue Dec 5, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Lentern
Copy link

Lentern commented Dec 5, 2021

Describe the bug
An update for TabTPS is prompted in the console every time the server starts even when the updated mod version is for a different Minecraft version

To Reproduce

  1. Add TabTPS 1.3.10 to 1.17.1 Fabric server
  2. Start it
  3. Watch the console; notice how it prompts you to update despite the mod being for a newer version of Minecraft

Expected behavior
No update prompt will appear

Screenshots
image

Server Software and Version:

  • Vendor: Fabric
  • Minecraft Version: 1.17.1
@Lentern Lentern added the bug Something isn't working label Dec 5, 2021
@jpenilla
Copy link
Owner

jpenilla commented Dec 5, 2021

The update checker can be disabled (update-checker in the main config file), and that would be my recommendation, to disable it once the Minecraft version you're running can't use the new update.

Sure, the update checker could be improved, but it's quite low priority for me, especially given Fabric is the only platform MiniMOTD supports which has a version-specific artifact (the Spigot, Bungee, Velocity, and Sponge plugins are tied to API versions, not Minecraft versions, and so you can usually always run the latest plugin version)

@jpenilla jpenilla added enhancement New feature or request and removed bug Something isn't working labels Dec 5, 2021
@jpenilla jpenilla changed the title Mod update is prompted even when the Minecraft version is different Take into account Minecraft version for update checks on Fabric Dec 5, 2021
@csthenry
Copy link

csthenry commented Jan 8, 2024

The update checker can be disabled (update-checker in the main config file), and that would be my recommendation, to disable it once the Minecraft version you're running can't use the new update.

Sure, the update checker could be improved, but it's quite low priority for me, especially given Fabric is the only platform MiniMOTD supports which has a version-specific artifact (the Spigot, Bungee, Velocity, and Sponge plugins are tied to API versions, not Minecraft versions, and so you can usually always run the latest plugin version)

# Should the plugin check GitHub for updates on startup?
update-checker=false

I made the above configuration, the updater still enabled and was not disabled as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants