Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate characters in keywords, symbols and tags #2

Open
jorinvo opened this issue Aug 19, 2020 · 0 comments
Open

Validate characters in keywords, symbols and tags #2

jorinvo opened this issue Aug 19, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jorinvo
Copy link
Owner

jorinvo commented Aug 19, 2020 •
edited

To generate valid EDN, we need to validate what characters are allowed in keywords and symbols when generating EDN.

They also must contain not more than one slash, which is not allowed to be the first or last char.
And in the case of tags, they even must contain a slash if it's a custom tag provided by the user.

If invalid chars are given, throw an error.
@jorinvo jorinvo added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed and removed bug Something isn't working labels Aug 19, 2020
@jorinvo jorinvo changed the title Validate allowed characters in keywords and symbols Validate characters in keywords and symbols Aug 19, 2020
@jorinvo jorinvo changed the title Validate characters in keywords and symbols Validate characters in keywords, symbols and tags Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorinvo