Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Unclear instruction on joomla update #43408

Open
ChristineWk opened this issue Apr 30, 2024 · 15 comments
Open

[4.4] Unclear instruction on joomla update #43408

ChristineWk opened this issue Apr 30, 2024 · 15 comments

Comments

@ChristineWk
Copy link

ChristineWk commented Apr 30, 2024

Steps to reproduce the issue

The checkbox is invisible. It is not clear that you have to click this button before the update. It's just a note that a backup is recommended.

Expected result

There should be a different text there, something like "Only after confirmation ............ etc." Because it is not obvious that you "have to" click on the checkbox beforehand.

The checkbox should be more visible.

System information (as much as possible)

Joomla 4 and above

@ChristineWk
Copy link
Author

update-info

@chmst chmst added the UI/UX label Apr 30, 2024
@exlemor
Copy link

exlemor commented May 1, 2024

Hi @ChristineWk, great thought.

To make it easier and to have it go through faster, it would be great if you proposed a or a couple of better versions, then a PR can be made easily/faster if found to make sense.

@Sieger66
Copy link
Contributor

Sieger66 commented May 1, 2024

Language Constant is:
COM_JOOMLAUPDATE_UPDATE_CONFIRM_BACKUP

example for CSS:

.com_joomlaupdate .form-check-input[type=checkbox] {
outline: medium solid var(--focus);
outline-offset: .2em;
}


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43408.

@chmst
Copy link
Contributor

chmst commented May 1, 2024

We all are german and need help of a native speaker.
My suggestion is something like
"yes, I am aware that a backup is highly recommended before starting the backup"

Other checkboxes in list views have been improved in 5.1. #41400

@brianteeman
Copy link
Contributor

Maybe the german needs adjusting, I don't know, but the english makes perfect sense to me (now that the checkbox is more visible)

@chmst
Copy link
Contributor

chmst commented May 2, 2024

Agree with instructions. English is clear, German is not @tecpromotion

But the issue of invisible check box remains. Other checkboxes are better now, but not this one. It has another class than the checkboxes in listviews.

grafik

@tecpromotion
Copy link
Contributor

@ChristineWk @chmst
https://github.com/joomlagerman/joomla/issues/new/choose

@brianteeman
Copy link
Contributor

But the issue of invisible check box remains. Other checkboxes are better now, but not this one. It has another class than the checkboxes in listviews.

Don't forget that in the screenshot the checkbox is disabled. Its not enabled (and more visible) until you have selected a file

image

image

@Pinkeltje
Copy link

Text is more visible, but checkbox still isn't.
This would solve it:
Change:
--form-check-input-border: var(--border-width) solid var(--template-bg-dark-20);
to
--form-check-input-border: var(--border-width) solid var(--template-bg-dark-80);
2024-05-04 Screenshot 329

@chmst
Copy link
Contributor

chmst commented May 4, 2024

I think that a more userfriendly solution would be:
Hide the second block until the user has selected a file, then make it visible.
Then it is not necessary to disable a text which for users looks like a bug and has no a11y contrast.

@brianteeman
Copy link
Contributor

brianteeman commented May 4, 2024

Text or images of text that are part of an inactive user interface component, that are pure decoration, that are not visible to anyone, or that are part of a picture that contains significant other visual content, have no contrast requirement.

https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html

@chmst
Copy link
Contributor

chmst commented May 4, 2024

I know that and did not label it as a11y issue.

@brianteeman
Copy link
Contributor

has no a11y contrast.

sorry, i saw that so commented

@Pinkeltje
Copy link

Pinkeltje commented May 4, 2024

The original issue is not about the text but about the checkbox that is barely visible. One of my customers called me some time ago with the same issue "can't update". Turned out he hadn't seen the checkbox.
Joomla 4
2024-05-04 Screenshot 332
Joomla 5
2024-05-04 Screenshot 333
Different css though:
.form-check-input { border: var(--border-width)solid var(--border-color); }
--border-color: #dee2e6;

@ChristineWk
Copy link
Author

ChristineWk commented May 4, 2024

The issue joomlagerman is outsourced and therefore treated separately.
Thanks for the suggestions about the checkbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants