New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Config-able screenshare bitrate #2125

Open

psi-4ward opened this issue Sep 30, 2022 · 0 comments

Contributor

psi-4ward commented Sep 30, 2022

See ad75454#diff-20e543a222fca71d2e2b99c286bbc60db44e228bb3cfc9d8a083d835140abdb0R2371

            const isSharingScreen = FeatureFlags.isMultiStreamSupportEnabled()
                ? mid === getDesktopTrackMid()
                : this._isSharingScreen();
            const limit = Math.floor((isSharingScreen ? HD_BITRATE : hdBitrate) / 1000);

We use here the hardcoded constant HD_BITRATE for Screenshare. Would be nice to have it config-able using config.js ie

    videoQuality: {
        preferredCodec: 'VP9',
        enforcePreferredCodec: true,
        maxBitratesVideo: {
            VP9: {
                low: 100000,
                standard: 300000,
                high: 750000,
                screenshare: 500000
            }
        },
    },

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment