You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi
Great work with it, but can you modify JS syntax highlight? "this" isn't highlighted as keyword. Ofc. $this would be same color as variables, but "this" should be red as rest of keywords (like "var"). Nice to have :)
PS: One dark recognize this everywhere, so $this also has red color (not best but still good).
The text was updated successfully, but these errors were encountered:
Yeah I intentionally deviated from One Dark. Though this is a keyword, it's just an accessor for current object scope. For example, myObject.method() doesn't colour the object red, but this.method() does. This differs by theme though.
Dayle Rees' schemes were a big inspiration. Dayle doesn't seem to follow any specific standards as to what should be coloured and how. He seems to have a more artistic approach to things. Often his themes are based on very narrow palette (as low as 2 or 3 shades only), and so he's very conservative with what he colours and where.
Ultimately, I think it's subjective to opinion. I'll leave this open to discussion for now. Not sure where I stand :P
Hi
Great work with it, but can you modify JS syntax highlight? "this" isn't highlighted as keyword. Ofc. $this would be same color as variables, but "this" should be red as rest of keywords (like "var"). Nice to have :)
PS: One dark recognize this everywhere, so $this also has red color (not best but still good).
The text was updated successfully, but these errors were encountered: