Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript syntax - this keyword #3

Open
kfalkiewicz opened this issue Jan 7, 2016 · 2 comments
Open

JavaScript syntax - this keyword #3

kfalkiewicz opened this issue Jan 7, 2016 · 2 comments

Comments

@kfalkiewicz
Copy link

Hi
Great work with it, but can you modify JS syntax highlight? "this" isn't highlighted as keyword. Ofc. $this would be same color as variables, but "this" should be red as rest of keywords (like "var"). Nice to have :)

PS: One dark recognize this everywhere, so $this also has red color (not best but still good).

@jesseleite
Copy link
Owner

Thanks for kind words.

Yeah I intentionally deviated from One Dark. Though this is a keyword, it's just an accessor for current object scope. For example, myObject.method() doesn't colour the object red, but this.method() does. This differs by theme though.

Dayle Rees' schemes were a big inspiration. Dayle doesn't seem to follow any specific standards as to what should be coloured and how. He seems to have a more artistic approach to things. Often his themes are based on very narrow palette (as low as 2 or 3 shades only), and so he's very conservative with what he colours and where.

Ultimately, I think it's subjective to opinion. I'll leave this open to discussion for now. Not sure where I stand :P

@MadcapJake
Copy link

You can always add it yourself via the custom stylesheet Atom provides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants