-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no version number "go install" procedure #3545
Comments
I don't think I'd consider this a bug. To include the version number in the build, you have to tell go to do that by doing something like |
manually specifying the version number is very inconvenient and error-prone (expecially regarding automatic updates)... other programs installed in the exact same way do it automatically (so I guess there is also a way for LazyGit to do it automatically and without user intervention).
you get its correct version number:
|
I am no expert in Go, so sadly I have completely no idea about suggestions on how it can be done :( |
fzf does it by hard-coding the version number in the source code. We don't want to do this for several reasons. Also, it's quite a deliberate decision that packaged builds have a version number, but manual builds do not. For example, packaged builds will show a "breaking changes" message when you upgrade from one version to the next; manual builds don't, because you might be in between versions, so it wouldn't be clear when to show the message. My take on this is that if you insist to install lazygit manually, you get what you asked for; if you want to have a version number, install an official, packaged build. What package manager are you using, and is there a reason why you don't use the lazygit package that it provides? |
I compile it from source because I don't have root/sudoer permission on the server I'm working on: I cannot use the regular package manager. Reading your answer, I think I can be misinterpreting one point: I think that assigning some sort of unique number/identifier to manual builds is very useful. For example, if I install LazyGit from source and my build has no version number, how can my bug reports be any useful to the developers? The entire setup will not be reproducible... Anyway, thank you for this very useful piece of software. |
It installs the last tagged release, but using |
I see. In that case, I recommend to clone the lazygit repo, cd into it, and type As far as I can tell, there is no way for us to achieve the same thing when you use |
Describe the bug
latest LazyGit version is v0.41.0 but this number doesn't show with
lazygit --version
if the (latest) package is installed bygo install
.this also wrongly triggers the internal update manager.
To Reproduce
the output is:
commit=, build date=, build source=unknown, version=unversioned, os=linux, arch=amd64, git version=2.34.1
which has no information about the version number
Expected behavior
version=0.41.0
in the output of the above commandsThe text was updated successfully, but these errors were encountered: