Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Launching a panel with a specified window size. #3042

Open
thenbe opened this issue Sep 30, 2023 · 0 comments · May be fixed by #3223
Open

[feature request] Launching a panel with a specified window size. #3042

thenbe opened this issue Sep 30, 2023 · 0 comments · May be fixed by #3223
Labels
enhancement New feature or request

Comments

@thenbe
Copy link

thenbe commented Sep 30, 2023

As I understand it, there are three view size: full, half, normal.

There is a single key in the config file that utilizes the 3 view sizes mentioned above, gui.windowSize. This key only affects the "main" window, which is the one you are presented with just running lazygit without positional args. This all works great.

However, when using positional args (i.e. lazygit stash or lazygit log), the key above does not take effect. I'm not proposing that it should. Instead, I'd like to suggest a new key gui.panelWindowSize (name up for bike-shedding), which controls the default view mode when launching lazygit with a positional argument.

Why?

  1. lazygit stash, in most situations, isn't very useful unless you press _ once (to half) to see the diff because the stash names all look similar so it's difficult to know which is which.

  2. If your workflow has you opening lazygit (stash|log|branch) in a full-screen window (as opposed to a tmux vertical split), then you almost always have a lot (right half+ of the screen) of empty space anyways. So it would make sense for you to set this new flag to half.

@thenbe thenbe added the enhancement New feature or request label Sep 30, 2023
ayyess added a commit to ayyess/lazygit that referenced this issue Jan 15, 2024
Previously, lazygit status, log, or branch always opened in a full
window size regardless of the gui.windowSize value. Now,
gui.panelWindowSize configures the window size per arg (and no arg can
be configured as "main") regardless of requested filter path.

Closes jesseduffield#3042
@ayyess ayyess linked a pull request Jan 15, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant