Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Do Not Disturb is on, warn user on focus page #376

Open
dpaulino opened this issue Jun 22, 2023 · 3 comments
Open

If Do Not Disturb is on, warn user on focus page #376

dpaulino opened this issue Jun 22, 2023 · 3 comments
Assignees

Comments

@dpaulino
Copy link
Contributor

dpaulino commented Jun 22, 2023

Current problem:

  • Users with Do Not Disturb on will not see any of ambie's focus notifications.
  • Ideally, users would grant an exception for Ambie's notifications
  • To mitigate, we should add a message somewhere on the focus page recommending that users add an exception

Note: investigation has shown there is no way for a UWP app to detect if Do Not Disturb is on. So this issue might never be resolved.

@AnalogFeelings
Copy link
Contributor

working on it

@dpaulino
Copy link
Contributor Author

dpaulino commented Sep 2, 2023

@AnalogFeelings first off, I want to thank you for the contribution you've made with ambie for this issue and for others! You've been a great help. Unfortunately for this particular issue, I realize there was a problem in the requirements I listed. What I should have said was "If Do Not Disturb is on, warn user on focus page".

The work you did correctly addresses the scenario for focus mode, but I made the mistake in the original issue. Making things worse, as you investigated, there is no way for a UWP app to determine if Do Not Disturb is on. So this issue might have reached a dead end.

Next steps:

  • I will edit the title of this ticket to correct my mistake
  • While your PR correctly addressed the focus mode issue, that was based on my incorrect info. So would you be able to close your pr for now?
  • I will leave this issue open in case we discover a way to detect Do Not Disturb from a uwp app

Let me know what you think

@dpaulino dpaulino changed the title If focus mode is on, warn user on focus page If Do Not Disturb is on, warn user on focus page Sep 2, 2023
@AnalogFeelings
Copy link
Contributor

Sure, hopefully Microsoft makes the DND API public soon or makes requesting a key a possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants