Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Links in Documentation Overview Section #1218

Open
ridamadara opened this issue Oct 1, 2023 · 6 comments
Open

Incorrect Links in Documentation Overview Section #1218

ridamadara opened this issue Oct 1, 2023 · 6 comments

Comments

@ridamadara
Copy link

On the Dulwich documentation website (https://www.dulwich.io/docs/), within the "Overview" section, there is a problem with two hyperlinks that are currently leading users to the incorrect locations:

  • AUTHORS
  • CONTRIBUTING

I am interested in contributing to this issue by rectifying these hyperlinks.

@jelmer
Copy link
Owner

jelmer commented Oct 1, 2023

See docs/index.txt for where these links come from; it's happening because we're including ../README.rst

@jelmer
Copy link
Owner

jelmer commented Oct 1, 2023

A possible resolution might be to replace the include with a different bit of text.

@ridamadara
Copy link
Author

ridamadara commented Oct 1, 2023

In this section of the README.rst, it's important to note that AUTHORS and <CONTRIBUTING.rst> are not functioning as regular web links but rather references to internal or local resources within the project. One potential solution to address this issue could be to replace these tags with direct web links to their respective GitHub pages. This solution would involve making relatively minor modifications to the README.rst file.
dulwich-readme-screenshot

@jelmer
Copy link
Owner

jelmer commented Oct 1, 2023

Please keep this URLs relative - they shouldn't go to GitHub when dulwich' README is displayed elsewhere, and if you're viewing them in another branch it shouldn't take you back to master.

@ridamadara
Copy link
Author

To address this concern, we can create a new file specifically for the website that mirrors the README content. Within this file, we'll include URLs specifically redirected to the master branch. This way, when users visit the documentation on the website, the URLs will work as intended.

@jelmer
Copy link
Owner

jelmer commented Oct 4, 2023

That sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants