Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly detect dm devices #298

Open
avishayt opened this issue Jan 31, 2022 · 3 comments · May be fixed by #301
Open

Properly detect dm devices #298

avishayt opened this issue Jan 31, 2022 · 3 comments · May be fixed by #301

Comments

@avishayt
Copy link
Contributor

With multipath, we currently see that the drive type is "unknown". It would be great to see it as "multipath" or even something more generic such as "mapper", and it would be even greater to see which other devices were associated with it.

avishayt added a commit to avishayt/ghw that referenced this issue Jan 31, 2022
@avishayt avishayt linked a pull request Jan 31, 2022 that will close this issue
avishayt added a commit to avishayt/ghw that referenced this issue Mar 15, 2022
Fixes: jaypipes#298
Signed-off-by: Avishay Traeger <avishay@redhat.com>
avishayt added a commit to avishayt/ghw that referenced this issue Mar 15, 2022
Fixes: jaypipes#298
Signed-off-by: Avishay Traeger <avishay@redhat.com>
@jaypipes
Copy link
Owner

@avishayt @fromanirh I am hesitant to support multipath "devices" just like I am hesitant to support loopback devices.

This hesitation is especially true for mapper "devices" which aren't really devices at all and represent an abstraction above devices.

@ffromani
Copy link
Collaborator

That's a good point indeed. These are abstractions provided by the linux kernel which happen to be presented using the same interface as the real devices. From this perspective it is out of scope from a hardware abstraction library.

Maybe it's too early, but it seems there it seems to be a trend emerging about features like DM and loopback which are not hardware proper but are traditionally modeled as block devicse and are similar enough to hardware to have a real use cases.

I'm really thinking aloud, but maybe a way forward could be worth to have something like a ghw companion/extension library to handle pseudo devices? I'll file a issue in the future to discuss this option.

@jaypipes
Copy link
Owner

@avishayt @fromanirh I might be convinced to add an entirely separate Go package for devicemappers, though. Such a package would treat device mappings/mappers as a separate construct (that would reference pkg/block.Disk structs within it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants