You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I am trying to set up a Validator associated with my query parameters, which are wrapped inside a class and marked as [FromQuery] inside of the action method of the controller.
My Controller looks like this one:
public async Task<ActionResult> GetVehicles([FromQuery] VehicleRequestDto requestDto)
My Dto:
public class VehicleRequestDto
{
public int? PageNumber { get; set; }
}
my validator validator
public class VehicleRequestDtoValidator : AbstractValidator<VehicleRequestDto>
{
public VehicleRequestDtoValidator()
{
RuleFor(x => x.PageNumber)
.GreaterThan(0)
.WithMessage("This is my super validation message");
}
}
Keeping the AddFluentValidationFromAssembly(...)
but it never hits the validator before hitting the controller, also in the ValidationBehaviour I am not getting any validators
To Reproduce
Steps to reproduce the behavior:
Create a Dto
public class VehicleRequestDto
{
public int PageNumber { get; set; }
}
Create a Validator for the Dto instead of the query handler and try to call the endpoint
It hits the controller endpoint but never triggers the validator or passes any validators to the ValidationBehaviour to get executed. Also, check that ValidationBehaviour is executing an async call to ValidateAsync when the .net core pipeline is sync.
Please also check and reconsider removing the library from the solution and use manual validation instead, eventually if this is the case, I think the ValidationBehaviour is going to go away.
The text was updated successfully, but these errors were encountered:
zinov
changed the title
Is FluentValidation Working for the endpoints you create?
FluentValidation not working for the endpoints you create with plain dtos intestead of queryhandlers?
Mar 26, 2024
zinov
changed the title
FluentValidation not working for the endpoints you create with plain dtos intestead of queryhandlers?
FluentValidation not working for the endpoints you create with plain dtos?
Mar 26, 2024
zinov
changed the title
FluentValidation not working for the endpoints you create with plain dtos?
FluentValidation not triggered after Model Binding
Mar 27, 2024
zinov
changed the title
FluentValidation not triggered after Model Binding
FluentValidation not triggered
Mar 27, 2024
First I am not from clean architecture team, But is this issue related to this clean architecture project template. My recommendation is try set up FluentValidation in separate project. Feel like your issue is related to AddFluentValidationFromAssembly.
Describe the bug
I am trying to set up a Validator associated with my query parameters, which are wrapped inside a class and marked as [FromQuery] inside of the action method of the controller.
My Controller looks like this one:
public async Task<ActionResult> GetVehicles([FromQuery] VehicleRequestDto requestDto)
My Dto:
my validator validator
Keeping the AddFluentValidationFromAssembly(...)
but it never hits the validator before hitting the controller, also in the ValidationBehaviour I am not getting any validators
To Reproduce
Steps to reproduce the behavior:
Create a Dto
public class VehicleRequestDto
{
public int PageNumber { get; set; }
}
Create a Validator for the Dto instead of the query handler and try to call the endpoint
It hits the controller endpoint but never triggers the validator or passes any validators to the ValidationBehaviour to get executed. Also, check that ValidationBehaviour is executing an async call to ValidateAsync when the .net core pipeline is sync.
Please also check and reconsider removing the library from the solution and use manual validation instead, eventually if this is the case, I think the ValidationBehaviour is going to go away.
FluentValidation/FluentValidation#1959
dotnet/aspnetcore#31905
The text was updated successfully, but these errors were encountered: