Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equivalent of "hover" for touch displays #3145

Open
pljones opened this issue Aug 12, 2023 · 4 comments
Open

Add equivalent of "hover" for touch displays #3145

pljones opened this issue Aug 12, 2023 · 4 comments
Labels
feature request Feature request
Milestone

Comments

@pljones
Copy link
Collaborator

pljones commented Aug 12, 2023

What is the current behaviour and why should it be changed?

On desktop builds, hovering the mouse over the channel user displays their profile details in a tool tip:
image

As no "hover" action is available for touch displays (e.g. Android), this feature is unavailable.

Describe possible approaches

A single tap or, probably better, long-hold could be used to display tool tips in general. (Long-hold would avoid misinterpretation of single tap on a checkbox or menu, etc.)

I'm guessing touch screens also are missing right-click "What's this?" support. Possibly that could be implemented as above, with "Show musician profile" as an extra option where applicable.

Other trigger actions could be double tap or two-finger tap. Long-hold is prefered, I think.

Has this feature been discussed and generally agreed?

Only with my partner, who raised it.

@pljones pljones added the feature request Feature request label Aug 12, 2023
@ann0see
Copy link
Member

ann0see commented Aug 12, 2023

Long tap should be the way to go.

@pljones
Copy link
Collaborator Author

pljones commented Aug 13, 2023

OK https://doc.qt.io/qt-6/qtapandholdgesture.html has been around since qt4.8 or earlier, so it looks like gesture support is pretty solid. I propose to update any object supporting "What's this?" with an additional trigger of tap-hold and, for the musician profile, to add that to the tap-hold menu.

Edit: So editing the default Shift-F1 / right-click / help menu behaviour is "not simple"; neither is routing tap-hold to hover (as it's tap-hold finished). For now, I'll just add tap-hold to the one component.

Edit2: Ugh... and gestures use QWidget::event() rather than sending a signal!

Edit3: Oh dear... https://doc.qt.io/qt-6/moc.html#multiple-inheritance-requires-qobject-to-be-first so overriding event() has to be done explicitly per class and can't reuse code (either to convert the event to a signal or to handle the event).

pljones added a commit to pljones/jamulus that referenced this issue Aug 13, 2023
@pljones
Copy link
Collaborator Author

pljones commented Aug 13, 2023

Well, that didn't work. Doesn't appear to have broken the Windows build but long hold did nothing... I'll have to investigate further.

pljones added a commit to pljones/jamulus that referenced this issue Aug 15, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 23, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 25, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 28, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 28, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 28, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 28, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 28, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 30, 2023
@pljones pljones added this to the Release 3.11.0 milestone Aug 30, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 30, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 30, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 30, 2023
pljones added a commit to pljones/jamulus that referenced this issue Aug 30, 2023
pljones added a commit to pljones/jamulus that referenced this issue Sep 5, 2023
pljones added a commit to pljones/jamulus that referenced this issue Sep 12, 2023
pljones added a commit to pljones/jamulus that referenced this issue Sep 18, 2023
pljones added a commit to pljones/jamulus that referenced this issue Sep 27, 2023
@pljones pljones self-assigned this Sep 27, 2023
pljones added a commit to pljones/jamulus that referenced this issue Oct 2, 2023
pljones added a commit to pljones/jamulus that referenced this issue Oct 5, 2023
pljones added a commit to pljones/jamulus that referenced this issue Oct 7, 2023
pljones added a commit to pljones/jamulus that referenced this issue Oct 7, 2023
pljones added a commit to pljones/jamulus that referenced this issue Oct 7, 2023
pljones added a commit to pljones/jamulus that referenced this issue Oct 7, 2023
pljones added a commit to pljones/jamulus that referenced this issue Oct 15, 2023
pljones added a commit to pljones/jamulus that referenced this issue Oct 15, 2023
pljones added a commit to pljones/jamulus that referenced this issue Nov 2, 2023
pljones added a commit to pljones/jamulus that referenced this issue Nov 2, 2023
pljones added a commit to pljones/jamulus that referenced this issue Dec 9, 2023
pljones added a commit to pljones/jamulus that referenced this issue Dec 9, 2023
pljones added a commit to pljones/jamulus that referenced this issue Dec 14, 2023
pljones added a commit to pljones/jamulus that referenced this issue Dec 14, 2023
pljones added a commit to pljones/jamulus that referenced this issue Jan 14, 2024
pljones added a commit to pljones/jamulus that referenced this issue Jan 14, 2024
pljones added a commit to pljones/jamulus that referenced this issue Feb 12, 2024
pljones added a commit to pljones/jamulus that referenced this issue Feb 12, 2024
pljones added a commit to pljones/jamulus that referenced this issue Feb 18, 2024
pljones added a commit to pljones/jamulus that referenced this issue Feb 18, 2024
pljones added a commit to pljones/jamulus that referenced this issue Mar 5, 2024
pljones added a commit to pljones/jamulus that referenced this issue Mar 5, 2024
pljones added a commit to pljones/jamulus that referenced this issue Mar 15, 2024
pljones added a commit to pljones/jamulus that referenced this issue Mar 15, 2024
pljones added a commit to pljones/jamulus that referenced this issue Mar 28, 2024
pljones added a commit to pljones/jamulus that referenced this issue Mar 28, 2024
@pljones
Copy link
Collaborator Author

pljones commented Mar 28, 2024

I'm going to de-assign myself from this: my Android-foo hasn't got me any progress on it so far.

@pljones pljones removed their assignment Mar 28, 2024
@pljones pljones modified the milestones: Release 3.11.0, 3.12.0, Release 3.12.0, Release 4.0.0 May 3, 2024
pljones added a commit to pljones/jamulus that referenced this issue May 6, 2024
pljones added a commit to pljones/jamulus that referenced this issue May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Status: Triage
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants