-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden Jamulus server for unwanted connections #3107
Comments
Is this code change intended to thwart the connection floods we've seen? I believe those floods aren't possible when a server's firewall blocks UDP packets from random sources. Would this code change benefit servers that block random UDP packets? |
There's no code yet, but yes, it should make the software a bit stricter.
The problem is: how would you conclude that some source is "random"? Having a firewall surely helps. |
It would be good to see if we can even reproduce the observed behaviour on modern servers. Maybe bIsIdentified is enough |
A source is random when it doesn't rely on the directory server to open a connection prior to use. I believe this prevents random connections outside the directory protocol from reaching a server. So my servers should be immune to this particular attack. I could open UDP and make a server susceptible to that type of attack. Of course, private servers (more accurately called unlisted servers) must open UDP to anyone. |
Ok. But as you said that doesn't hold true for unlisted servers or direct connections. So that's only a small "solution" if you even want to call it that. |
Thanks for watching out for users in all scenarios. I do limit my scope to developing the directory-based public network. |
Even though #2935 is already old, I think we should still consider hardening the "connection" process.
@dtinth proposed a "waiting room" approach, which we kind of already have (we already have something like this:
jamulus/src/channel.cpp
Line 39 in 2505a31
Originally posted by @dtinth in #2935 (comment)
The text was updated successfully, but these errors were encountered: