Shall we change a diagnose command output column name #51024
xulingqing
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We recently had an incident where a customer misread the output of
istioctl proxy-config secret
, which looks like this:Specifically, they thought that the date under NOT BEFORE was actually the NOT AFTER date.
Even though it's a little more natural to lay out the dates as "NOT BEFORE" first and "NOT AFTER" second, it is probably too late to do that because the command has had that format for 5 years and it people may depend on the format now.
Would it make the output more understandable if we renamed "NOT AFTER" to "VALID ON OR BEFORE" and "NOT BEFORE" to "VALID ON OR AFTER"? And if so, is it okay to make that change? cc @johnhoward
The headers are defined here:
istio/istioctl/pkg/writer/compare/sds/writer.go
Line 72 in f6a08fa
Beta Was this translation helpful? Give feedback.
All reactions