Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for conf_validations #65

Open
riley-harper opened this issue Dec 1, 2022 · 0 comments
Open

Improve tests for conf_validations #65

riley-harper opened this issue Dec 1, 2022 · 0 comments
Labels
tests Unit and integration tests for code

Comments

@riley-harper
Copy link
Contributor

The conf_validations module is not particularly well tested. We should at least have one test that has a valid config file so that we can confirm that all of the steps run without errors on a valid config file.

There are lots of edge cases and error conditions to be triggered during config validation. Trying to hit all of them is probably not worth it, at least for this issue, but hitting some of the more important or fragile ones may be helpful. It is helpful that the module is divided into several smallish functions, which should make it easier to test.

@riley-harper riley-harper added the tests Unit and integration tests for code label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Unit and integration tests for code
Projects
None yet
Development

No branches or pull requests

1 participant