Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover the pip install . use case in GitHub Actions #33

Open
riley-harper opened this issue Aug 2, 2022 · 0 comments
Open

Cover the pip install . use case in GitHub Actions #33

riley-harper opened this issue Aug 2, 2022 · 0 comments

Comments

@riley-harper
Copy link
Contributor

Currently our GitHub Actions install hlink in editable mode with the -e flag and with additional development dependencies. We need to install the development dependencies for linting and testing, but we could probably get away with not passing the -e flag to pip install. This might help prevent some installation bugs where pip install .[dev] doesn't copy over needed resource files. We ran into one of these bugs recently with Jinja.

We may also want to set up some GitHub Actions that just run pip install . without installing development dependencies and then confirm that some of the basics of hlink are working as expected. pytest won't be installed in this situation since it's a development dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant