Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

graphsync spec - missing information about message framing #303

Open
chafey opened this issue Sep 25, 2020 · 2 comments
Open

graphsync spec - missing information about message framing #303

chafey opened this issue Sep 25, 2020 · 2 comments
Assignees

Comments

@chafey
Copy link
Contributor

chafey commented Sep 25, 2020

go-graphsync writes a varint containing the message size of the protobuf message before writing the actual message on the libp2p stream. This is done so the receiver of the message knows how big the actual message is so it can fully read it before trying to parse it. This should be documented as part of the spec to make it complete

@rvagg
Copy link
Member

rvagg commented Sep 25, 2020

Ouch, did you discover this when trying to implement it? Can you open a PR for it? The spec doesn't really have an owner as such on the team so if you're willing to take on touch-ups then that would be very helpful.

@chafey
Copy link
Contributor Author

chafey commented Sep 25, 2020

Yes, discovered while implementing js-graphsync. I'll submit a PR for this, perhaps with other changes I discover during implementation. Just wanted a place to keep track of it until then

@chafey chafey self-assigned this Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants