Update Makefile to support ppc64le #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runlevel5
commented
Aug 15, 2023
| @@ -377,6 +380,11 @@ ifneq (,$(findstring "$(PLATFORM)", "linux" "gnu_kfreebsd" "kfreebsd-gnu" "gnu") | |||
| ALTIVEC_CFLAGS = -maltivec | |||
| HAVE_VM_COMPILED=true | |||
| endif | |||
| ifeq ($(ARCH),ppc64le) | |||
| OPTIMIZE += -mcpu=power8 | |||
There was a problem hiding this comment.
power8 is the lowest common denominator for LE support
runlevel5
force-pushed
the
ppc64le
branch
3 times, most recently
from
8c6dfa2
to
faeb486
Compare
runlevel5
commented
Aug 16, 2023
Comment on lines
-427
to
-430
| else | ||
| ifeq ($(ARCH),ppc64) | ||
| BASE_CFLAGS += -m64 | ||
| endif |
There was a problem hiding this comment.
There is no need to declare -m64 because we have specify -mcpu=power7|power8 that automatically set -m64
runlevel5
commented
Aug 16, 2023
| ifeq ($(ARCH),ppc64) | ||
| ALTIVEC_CFLAGS = -maltivec |
There was a problem hiding this comment.
There is no need to explicitly declare -maltivec because -mcpu=power7 would set that automatically for us
|
Please resubmit when the PR is complete and ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #610