Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): malformed URIs will not throw exception #29486

Merged
merged 1 commit into from May 15, 2024

Conversation

sean-perkins
Copy link
Contributor

Issue number: resolves #29479


What is the current behavior?

If an application includes a malformed URI, an Ionic Framework can "crash" due to an uncaught exception in parsing the URI for the Ionic config.

What is the new behavior?

  • Handle the malformed URI fallback if the config cannot be determined
  • Added unit tests for this case

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 8:51pm

@github-actions github-actions bot added the package: core @ionic/core package label May 9, 2024
@sean-perkins sean-perkins marked this pull request as ready for review May 13, 2024 16:57
@sean-perkins sean-perkins requested a review from a team as a code owner May 13, 2024 16:57
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC
Copy link
Contributor

thetaPC commented May 13, 2024

Dev build: 8.1.2-dev.11715623495.196f4eba

@sean-perkins sean-perkins added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@brandyscarney brandyscarney added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 4a41983 May 15, 2024
59 checks passed
@brandyscarney brandyscarney deleted the sp/malformed-uris branch May 15, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: empty screen when URI is malformed
3 participants