Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probing end point #93

Open
steeling opened this issue Aug 22, 2019 · 0 comments
Open

Add probing end point #93

steeling opened this issue Aug 22, 2019 · 0 comments
Labels
dss Relating to one of the DSS implementations feature Issue would improve software P2 Normal priority
Milestone

Comments

@steeling
Copy link
Contributor

End to end tests are great for qualifying binaries and discovering bugs, but how do you test for liveness in production?

Probing! By adding an entirely separate set of endpoints /v1/probe/dss/...
To support gRPC probing we would need to duplicate and rename the service, ie: service ProbeDSService {...}

Note this is not part of the spec, but an implementation detail.

We definitely want to keep data separate, so the big question is if we would want to use separate tables or a separate database. I'd lean towards a separate database run within the same CRDB cluster, although that could potentially miss some cases where we bork the database (potentially due to a bad db migration push?). I think this is a small case to catch for larger wins in data separation. If the db is really messed up we will probably detect fairly quickly through traditional monitoring

@BenjaminPelletier BenjaminPelletier added this to the Post-demo milestone Aug 30, 2019
@BenjaminPelletier BenjaminPelletier added feature Issue would improve software P2 Normal priority and removed go-rewrite labels Jan 5, 2022
@BenjaminPelletier BenjaminPelletier added the dss Relating to one of the DSS implementations label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dss Relating to one of the DSS implementations feature Issue would improve software P2 Normal priority
Projects
None yet
Development

No branches or pull requests

2 participants