Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coalesce Subscriptions per callback URL #789

Open
BenjaminPelletier opened this issue Jun 10, 2022 · 1 comment
Open

Coalesce Subscriptions per callback URL #789

BenjaminPelletier opened this issue Jun 10, 2022 · 1 comment
Labels
bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations P2 Normal priority

Comments

@BenjaminPelletier
Copy link
Member

Currently, we report a Subscriber for each Subscription. Instead, we should coalesce per URL so that each unique URL only produces one SubscriberToNotify.

Is it correct to assume that there is always only one subscription ?

Originally posted by @barroco in #784 (comment)

@BenjaminPelletier
Copy link
Member Author

There may be many Subscriptions with the same callback URL, but that callback URL only needs to be invoked once. The SubscriberToNotify structure contains a list of Subscriptions that are triggering this (one) notification.

@BenjaminPelletier BenjaminPelletier added P2 Normal priority bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations P2 Normal priority
Projects
None yet
Development

No branches or pull requests

1 participant