Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easier issue if you know python] apply pep8 formatting to all files #59

Open
yochannah opened this issue Oct 23, 2019 · 5 comments
Open
Assignees
Labels
hacktoberfest contributors incredibly welcome!

Comments

@yochannah
Copy link
Member

We have pep8 speaks set up to check files that are edited in PRs - but we still have some files that aren't checked because they haven't been edited in a while.

Task: Apply pep8 formatting to all files in this repo. You probably want to try a command something like autopep8 . -r --in-place.

Note that this command might not fix all long lines - some might need to be done manually.

if you want to pick up this task

  1. Take a look at the InterMine contributing guidelines
  2. Comment on this issue stating that you intend to work on the task
  3. When you're ready, add your work to the repo and create a pull request.

What to do if you need help

Mention @yochannah, tweet @yoyehudi, pop by to say hi on chat or if needed email yo@intermine.org. Don't forget we're usually only available during uk office hours and will not be able to respond at other times :)

@yochannah yochannah added the hacktoberfest contributors incredibly welcome! label Oct 23, 2019
@ayham-1
Copy link

ayham-1 commented Oct 23, 2019

Hi @yochannah ! I would like to take this.

@yochannah
Copy link
Member Author

Awesome, go for it! 🚀

@ooo
Copy link

ooo bot commented Oct 25, 2019

👋 Hey @realaltffour...

Letting you know, @yochannah is currently OOO until Monday, October 28th 2019. ❤️

@mbasil09
Copy link
Contributor

mbasil09 commented Dec 9, 2019

@yochannah
If no one is working on it I would like to do so.
I was wondering if we could apply some external open source library like "coala-bears" to do this formatting. It would drastically reduce the effort.

@yochannah
Copy link
Member Author

@mbasil09 I think (just waiting for the CI to pass) that #62 probably has fixed the overal library formatting issue - BUT - you would be entirely welcome to implement coala-bears if you think it would make the pep8 formatting better! We have autopep8 at the minute, but it doesn't seem to quite catch everything straight away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest contributors incredibly welcome!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants