Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-Transfer-Encoding: binary is not decoded correctly #17

Open
xyzzy42 opened this issue Jan 27, 2021 · 0 comments
Open

Content-Transfer-Encoding: binary is not decoded correctly #17

xyzzy42 opened this issue Jan 27, 2021 · 0 comments

Comments

@xyzzy42
Copy link

xyzzy42 commented Jan 27, 2021

The problem is caused by the code in FFGET_getnewblock() that turns NUL bytes into spaces. The binary encoding of a binary file, such as an image, will most likely contain NUL bytes. Turning them into spaces will corrupt the file.

A workaround is to enable the undocumented --formdata option that disables the NUL to space conversion. However, it would be more correct to disable the conversion when processing the binary encoded data and turn it back on afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant