Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license for SHA1 implementation? #7

Open
pabs3 opened this issue Apr 27, 2021 · 2 comments
Open

license for SHA1 implementation? #7

pabs3 opened this issue Apr 27, 2021 · 2 comments

Comments

@pabs3
Copy link

pabs3 commented Apr 27, 2021

The SHA1 implementation in this repo by @B-Con does not appear to have any copyright or license information in it. I suggest that it needs to be either relicensed by @B-Con to the MIT license, or replaced with another freely licensed implementation, for example by linking with libmd.

PS: the two files should probably be updated from @B-Con's crypto-algorithms repo.

/*********************************************************************
* Filename:   sha1.c
* Author:     Brad Conte (brad AT bradconte.com)
* Copyright:
* Disclaimer: This code is presented "as is" without any guarantees.
* Details:    Implementation of the SHA1 hashing algorithm.
              Algorithm specification can be found here:
               * http://csrc.nist.gov/publications/fips/fips180-2/fips180-2withchangenotice.pdf
              This implementation uses little endian byte order.
*********************************************************************/
/*********************************************************************
* Filename:   sha1.h
* Author:     Brad Conte (brad AT bradconte.com)
* Copyright:
* Disclaimer: This code is presented "as is" without any guarantees.
* Details:    Defines the API for the corresponding SHA1 implementation.
*********************************************************************/
@pabs3
Copy link
Author

pabs3 commented Apr 27, 2021

PS: I note that the README.md file for the other project does say this:

This code is released into the public domain free of any restrictions. The author requests acknowledgement if the code is used, but does not require it. This code is provided free of any liability and without any quality claims by the author.

@pabs3
Copy link
Author

pabs3 commented Apr 27, 2021

@B-Con I think it would be useful to update the headers of all the files in the crypto-algorithms repo to mention that all the files are in the public domain. Also, since the public domain doesn't exist in some parts of the world, it would be good to place the code under the CC0 license in those jurisdictions.

Just switching to a linkable library like libmd would probably be a better idea though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant