Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microLB no longer builds with NaCl #2043

Open
AndreasAakesson opened this issue Feb 13, 2019 · 1 comment
Open

microLB no longer builds with NaCl #2043

AndreasAakesson opened this issue Feb 13, 2019 · 1 comment
Labels

Comments

@AndreasAakesson
Copy link
Contributor

The microLB constructor has changed multiple times on dev (related change: 612c86d), which makes NaCl outdated. From what I can see it's no longer possible to just change the one line constructing the object, since the option of either tcp, s2n or openssl. I'm not sure if this means the load balancer NaCl object also needs to extended or changed (@fwsGonzo and @AnnikaH maybe can see this).

It's also obvious either the OS test suite or NaCl needs to take responsible for making sure the microLB is actually built by NaCl to avoid changes like this going undiscovered.

@fwsGonzo
Copy link
Member

Did we solve this? By just making a constructor parameter have a default value, or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants