-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter names truncated when adding filter #4894
Comments
@svobs Would you be able to take this one? |
@low-batt Sure. Funny, I just refactored this dialog on my fork. I needed to rework most of the layout just to get the window to resize sanely. Should be straightforward to cut a PR. |
Thanks! That would be great! |
@svobs Just a little reminder on this one. We are planning on merging the RTL support and this is one of the RTL related issues. |
2 tasks
2 tasks
Duplicate of #1098. |
uiryuu
pushed a commit
that referenced
this issue
May 28, 2024
* Improvements to modernize & improve basic UX of Filters windows. This commit makes the following changes to Video Filters & Audio Filters windows: • Increase size of text & icons • Add save of window sizes & positions • Add double-click to Saved Filters table to edit saved filter • Ensure Filter Presets table (in Add Filter sheet) always has exactly 1 row selected, so that the sheet's Add button can no longer be clicked when nothing is selected • Fix multiple layout issues in Add Filter sheet which prevented window from resizing correctly • Increase width of Filter Presets table to provide extra space needed for some localizations * Increase height of Saved Filters row to accomodate larger text, decrease icon size slightly * Add minimum window size to Filters windows to prevent constraint violation errors * Set width of Filter Presets table intelligently based on width of its content * Fix +/- buttons appearing on wrong side in right-to-left locales in Filters windows * Fix truncated text * Fix incorrect box offsets introduced 2 commits ago
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System and IINA version:
Expected behavior:
Filter names are not truncated.
Actual behavior:
PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then the filter name for a custom FFmpeg filter is truncated in the sheet for adding a filter:
The table of filters should be automatically resized to adapt to the size of the filter names in other languages.
NOTE that this problem can also be reproduced using the
develop
branch and English. In Xcode openFilterWindowController.xib
. Built and run IINA. TheCustom (FFmpeg)
filter name is now truncated:Digging through all the changes to the XIB Xcode helpfully adds even if you only open the file in the editor and don't make any changes I see:
Xcode is messing with the width of table columns.
There are warning in the build log regarding layout problems:
This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this particular problem.
Steps to reproduce:
Pull PR feat: enable hebrew locale #4922
Open the IINA project in Xcode
Under the
Product
menu open theScheme
menu and selectEdit Scheme…
Click on the
Options
tabScroll down to the
App Language
settingIn the pull down select
Hebrew
Start IINA running under Xcode
Click on
Video Filters…
under theVideo
menuThe
Video Filters
window appearsClick on the
+
buttonThe sheet for adding a filter appears
Notice the last filter in the list is truncated
MPV does not have this problem.
mpv does not support localization.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: