Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement $drop(hard = TRUE) #47

Open
iferres opened this issue Jan 18, 2021 · 1 comment
Open

Implement $drop(hard = TRUE) #47

iferres opened this issue Jan 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@iferres
Copy link
Owner

iferres commented Jan 18, 2021

Implement an option to completely remove an organisms from the dataset. This would allow to then add metadata to available organisms without NAs needed for dropped ones. In the current implementation user must add metadata for all organisms, included the hidden ones. This makes it unnecessarily complicated if those organisms are garbage.

Suggested implementation:

p$drop( x = 1:4, hard = TRUE)

I now think default should be hard = FALSE (current behavior), but not sure.

@iferres
Copy link
Owner Author

iferres commented Jan 18, 2021

A note: this could help adding metadata to a pangenome with hidden organisms.

@iferres iferres added the enhancement New feature or request label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant