Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support jupyterhub 2.0 #96

Open
raybellwaves opened this issue Feb 1, 2022 · 6 comments
Open

support jupyterhub 2.0 #96

raybellwaves opened this issue Feb 1, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@raybellwaves
Copy link

I don't believe there's an issue open to add support for jupyterhub > 2

I believe cdsdashboards is currently pinned at <2 (e1d3ddb)

@raybellwaves raybellwaves added the enhancement New feature or request label Feb 1, 2022
@danlester
Copy link
Member

The most important thing in JupyterHub 2.0 is actually just configuration of the Hub itself, but it would certainly make sense for us to have some docs to explain best practices.

It sounds like you need to set a role on the default group, and also make sure all users are added to that default group. Some discussion here but I haven't had a chance to look into it myself.

Docs PRs are welcome for this!

@gsemet
Copy link

gsemet commented Oct 16, 2022

hello. What is really missing to have your project working with jhub >= 2?

@danlester
Copy link
Member

I think the main thing is to adapt to the RBAC roles introduced in JupyterHub 2.0.

Dashboards won't be accessible by anyone without doing something to open access to them via this new system... There are some ideas floating around above for opening up access to the dashboards, but another issue is doing this while also ensuring only the correct users are able to access their regular JupyterLab servers.

In general, I don't feel the JupyterHub team supports the idea of extending JupyterHub in the way that cdsdashboards does so. See here where we have asked about extensions: jupyterhub/jupyterhub#3416

They suggest that they would be more supportive if we got cdsdashboards out from the internals of JupyterHub into something more standalone that could access the JupyterHub API instead.

I don't have any funding to attempt something like that at this point!

@JohnCHarrington
Copy link

@danlester Any chance the recent RBAC changes in JupyterHub 3.0 will make this easier? https://jupyterhub.readthedocs.io/en/stable/changelog.html

@danlester
Copy link
Member

It sounds like they have identified some of the logical difficulties, but I think the solutions still lie in the same places - in the JupyterHub config which will be specific to each site. Thanks for sending the link.

@Debilski
Copy link

Maybe worth noting that current versions of Kubernetes (I think >= 1.25) will have problems running the ZTJH images for JupyterHub versions <2.0, at least when using the official Helm repo. (I managed with some ad-hoc upgrades to the kube-scheduler image.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants