Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Midi clock stop event does not stop a timeline. #22

Open
rvega opened this issue Feb 15, 2022 · 5 comments · May be fixed by #23
Open

Midi clock stop event does not stop a timeline. #22

rvega opened this issue Feb 15, 2022 · 5 comments · May be fixed by #23

Comments

@rvega
Copy link

rvega commented Feb 15, 2022 •
edited

I have something very simple like:

logging.basicConfig(level=logging.INFO, format="[%(asctime)s] %(message)s")

midi_in = iso.MidiInputDevice()
timeline = iso.Timeline(clock_source=midi_in)
timeline.schedule({
    "note": iso.PSequence([ 60, 67, 72, 77, 84 ],
    "duration": 0.5,
    "amplitude": iso.PWhite(0, 128)
}, delay=1)
timeline.run()

And I'm sending midi clock and start/stop events from a DAW.

What I'm trying to achieve is for the timeline/sequence to start/stop when the DAW sends the start/stop events and for it to be synced with the DAW's MIDI clock.
@rvega
Copy link
Author

rvega commented Feb 16, 2022

I did some additional tinkering and I set up my DAW to output MIDI song position pointer. Now what i see is:

The timeline responds to the DAW's start messages and tempo settings but when the stop message is received, the timeline keeps going and keeps outputing notes, also the message "Timeline: Stopping" is displayed.

@rvega
Copy link
Author

rvega commented Feb 16, 2022

Here's a PR that fixes this issue for me.
#23

@rvega rvega changed the title Can you please explain the interaction between a timeline and midi clock start/stop events? Midi clock stop event does not stop a timeline. Feb 16, 2022
@ideoforms
Copy link
Owner

Hey @rvega! Nice to see you here. Sorry for the slow reply, just working through a bit of a PR backlog...

What DAW are you using? I tested the current behaviour with Ableton Live and it works OK. But I've just been doing some reading and it sounds like some devices/DAWs continue to send MIDI clock events even when the transport is stopped, which I suspect may be what you're seeing here.

@ideoforms ideoforms linked a pull request Jan 3, 2024 that will close this issue
Disabling midi clock when stop message is received. #23
Open
@rvega
Copy link
Author

rvega commented Jan 5, 2024

Hi Daniel! @ideoforms
It's been a while since I used isobar, but I was using Bitwig under Arch Linux.

@ideoforms
Copy link
Owner

Thanks @rvega, that's great, I'll do some tests in Bitwig. This PR looks good though so I anticipate merging. Cheers and happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disabling midi clock when stop message is received. rvega/isobar
2 participants
@rvega @ideoforms