Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify friction implementation in the NSFV action #27634

Closed
kyriv1980 opened this issue May 15, 2024 · 0 comments
Closed

Clarify friction implementation in the NSFV action #27634

kyriv1980 opened this issue May 15, 2024 · 0 comments
Assignees
@kyriv1980
Labels
C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module T: task An enhancement to the software.

Comments

@kyriv1980
Copy link
Contributor

kyriv1980 commented May 15, 2024 •
edited

Motivation

There is an optional parameter in the PINSFVMomentumFriction kernel: standard_friction_formulation
that is in effect required in the NSFV action. This could be a cause of confusion. There is a default value associated with
it so the user shouldn't be forced to define it if they don't want to.

Design

Remove the error associated with the standard_friction_formulation parameter from the action, and improve the documentation.

Impact

Enhance clarity and user experience.
@kyriv1980 kyriv1980 added the T: task An enhancement to the software. label May 15, 2024
kyriv1980 added a commit to kyriv1980/moose that referenced this issue May 15, 2024
@kyriv1980
Clarify friction implementation in the NSFV action refs idaholab#27634
1f35e77
@kyriv1980 kyriv1980 mentioned this issue May 15, 2024
Merged
@lindsayad lindsayad added the C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module label May 15, 2024
kyriv1980 added a commit to kyriv1980/moose that referenced this issue May 15, 2024
@kyriv1980
Clarify friction implementation in the NSFV action refs idaholab#27634
b099175
kyriv1980 added a commit to kyriv1980/moose that referenced this issue May 15, 2024
@kyriv1980
Clarify friction implementation in the NSFV action refs idaholab#27634
9a5988a
kyriv1980 pushed a commit to kyriv1980/moose that referenced this issue May 15, 2024
@aeslaughter @kyriv1980
Clarify friction implementation in the NSFV action refs idaholab#27634
333e709
kyriv1980 pushed a commit to kyriv1980/moose that referenced this issue May 15, 2024
@aeslaughter @kyriv1980
Clarify friction implementation in the NSFV action refs idaholab#27634
bf946d0
kyriv1980 pushed a commit to kyriv1980/moose that referenced this issue May 15, 2024
@aeslaughter @kyriv1980
Clarify friction implementation in the NSFV action refs idaholab#27634
f702bb1
ke7kto pushed a commit to ke7kto/moose that referenced this issue May 22, 2024
@aeslaughter @ke7kto
Clarify friction implementation in the NSFV action refs idaholab#27634
4916786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyriv1980 kyriv1980

Labels
C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindsayad @kyriv1980