You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello there, first let me thank you for your excellent work on ILSpy as a long time user of the extension, it has been a huge help on both professional and personal projects.
I'm the author of package that auto generate documentation for csharp projects based on xml comments and metadata provided by your excellent ICSharpCode.Decompiler api. I have been using the CSharpAmbience.ConvertSymbol successfully to generate code definition in the auto generated pages for each members. I recently tried to add support for record and stumbled on a non expected result:
For the first issue, note the missing space between the record and struct keywords, I believe this is because we should add an explicit writer.Space() call here
Hello there, first let me thank you for your excellent work on ILSpy as a long time user of the extension, it has been a huge help on both professional and personal projects.
I'm the author of package that auto generate documentation for csharp projects based on xml comments and metadata provided by your excellent ICSharpCode.Decompiler api. I have been using the
CSharpAmbience.ConvertSymbol
successfully to generate code definition in the auto generated pages for each members. I recently tried to add support for record and stumbled on a non expected result:Steps to reproduce
For the first issue, note the missing space between the
record
andstruct
keywords, I believe this is because we should add an explicitwriter.Space()
call hereILSpy/ICSharpCode.Decompiler/CSharp/OutputVisitor/CSharpAmbience.cs
Line 87 in cfb4f0f
For the second issue, note the
set;
instead of the expectedinit;
, I believe there is some missing specific handling hereILSpy/ICSharpCode.Decompiler/CSharp/OutputVisitor/CSharpAmbience.cs
Line 194 in cfb4f0f
Details
I expect this is probably low priority as people using your API like this are probably few and far between but thanks anyway for your hard work :)
The text was updated successfully, but these errors were encountered: