Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of hulse-py client #4

Open
4 tasks
sachalevy opened this issue May 28, 2022 · 0 comments
Open
4 tasks

Refactoring of hulse-py client #4

sachalevy opened this issue May 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@sachalevy
Copy link
Member

sachalevy commented May 28, 2022 •
edited

Minor Refactoring

As pointed out by @ilaffey2, some functions are currently misplaced/hard to understand. Notably:

  • merge the query client and the utils post_query functions
  • move the get_auth_headers to the utils file
  • simplify api_key flow in the client by only leaving one entry point + setters/getters
  • add sample response in docs/docstring of process_stream_data
@sachalevy sachalevy added the enhancement New feature or request label May 28, 2022
@sachalevy sachalevy assigned ilaffey2 and sachalevy and unassigned ilaffey2 and sachalevy May 28, 2022
@ilaffey2 ilaffey2 mentioned this issue May 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilaffey2 @sachalevy