Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Model inspector for other formats #578

Open
madgetr opened this issue Mar 25, 2024 · 4 comments
Open

[Feature Request] Model inspector for other formats #578

madgetr opened this issue Mar 25, 2024 · 4 comments

Comments

@madgetr
Copy link
Contributor

madgetr commented Mar 25, 2024

Is there a plan to add model inspector support for other model formats? Currently, it seems that only safetensors and GGUF are supported.
image
I know that these other formats are not easily analyzed without the entire file on hand, but perhaps the tensor shapes and model metadata could be extracted on your backend at the same time as pickle and virus scanning.

@madgetr madgetr changed the title Model inspector for other formats [Feature Request] Model inspector for other formats Mar 25, 2024
@julien-c
Copy link
Member

@madgetr which formats are you looking for? the reason why we implemented for GGUF and Safetensors (in addition to the fact that's it doable over the network, like you mention) are because those are safe unlike pytorch pickles, so we encourage their use

@madgetr
Copy link
Contributor Author

madgetr commented Mar 25, 2024

I was thinking it would be interesting if you could see this data for the various other formats floating around such as pytorch, onnx, flax etc.

@julien-c
Copy link
Member

julien-c commented Mar 25, 2024

onnx might be doable (it's protobuf based IIRC). The others i'm not so keen bc they're unsafe formats so we want to push users away from those anyways

@madgetr
Copy link
Contributor Author

madgetr commented Mar 25, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants