Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Pekko HTTP? #780

Open
luksow opened this issue Feb 15, 2023 · 6 comments
Open

Support for Pekko HTTP? #780

luksow opened this issue Feb 15, 2023 · 6 comments

Comments

@luksow
Copy link

luksow commented Feb 15, 2023

Hi!

First of all, thank you for supporting such an important project for Akka HTTP users!

My issue is rather a question to the maintainers (so probably @hseeberger), what's your take on supporting Pekko HTTP?

Pekko now reached nightly releases, so it's high time to think about akka-http-json but for Pekko. Options I think are that either this project would be a place for it or a fork will be needed.

I'm happy to help and do some legwork but before that, I'd like to hear from you.

@hseeberger
Copy link
Owner

Hi @luksow, I do no longer actively maintain this project. Sorry.

@luksow
Copy link
Author

luksow commented Feb 15, 2023

@hseeberger oh, I see. Is there someone else with merge privileges?

@hseeberger
Copy link
Owner

I don't think so.

@pjfanning
Copy link

I forked akka-http-json and created https://github.com/pjfanning/pekko-http-json

I pushed snapshot jars to:
https://oss.sonatype.org/content/repositories/snapshots/com/github/pjfanning/

Thanks @hseeberger for all the amazing work you've done on akka-http-json and all your other projects. I think it is useful to have a pekko equivalent of these akka-http-json libs.

@hseeberger
Copy link
Owner

Thanks @pjfanning to take this project further.

Do you think it could make sense to either make you a maintainer of this project or transfer it to some other organization first and then make you maintainer? Might be easier for the existing user base.

@pjfanning
Copy link

@hseeberger I'm not really sure what the best way forward is. Most of the code in this repo depends on 'akka' classes and while the Pekko equivalents are basically the same except for the package names - the classes are still not compatible. So it feels like the Akka and Pekko modules won't share much code. To take as an example, Jackson, it's possible to rewrite the code to support Scala 3 but that change would probably need to be applied separately to the Akka and Pekko Jackson modules.

At the moment Pekko HTTP is far from complete and the build.sbt will need to be updated regularly with new snapshot version numbers. This means maintaining my own personal fork is easier, for now.

Maybe in a few months, when Pekko HTTP is released, we can look again at the options around adding Pekko modules to this Github project or a successor project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants