Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for orphan nodes #67

Open
robsavoye opened this issue Nov 1, 2021 · 3 comments
Open

Look for orphan nodes #67

robsavoye opened this issue Nov 1, 2021 · 3 comments
Assignees

Comments

@robsavoye
Copy link
Collaborator

The data validation in Underpass should be extended to look for orphan nodes in the osmchange file. Orphan nodes are nodes with no tags and not part of a way.

@mmd-osm
Copy link

mmd-osm commented Nov 1, 2021

This definition seems a bit incomplete. Nodes without tags might still be used in relations, such as https://www.openstreetmap.org/node/5726500366 as part of https://www.openstreetmap.org/relation/8415506

@robsavoye robsavoye self-assigned this Nov 1, 2021
@robsavoye
Copy link
Collaborator Author

Sure, and since the data is limited to what's in the osmchange file, it's not always possible to determine if a new node is part of an existing way. This was a requested feature, so this issue is mostly a placeholder so it doesn't get lost. This description should be extended to relations in addition to ways.

@mmd-osm
Copy link

mmd-osm commented Apr 15, 2022

Minutely diffs are not really suitable for analytical use cases. You'd always have to process them alongside your local planet database and perform database lookups as needed. That's probably not an issue as long as people are only adding new buildings. Beyond that you're running into all sorts of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants