Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation link for postgres docker image is broken #4223

Open
Tracked by #5705
Abhirup-99 opened this issue Feb 10, 2021 · 5 comments · May be fixed by #6331
Open
Tracked by #5705

Documentation link for postgres docker image is broken #4223

Abhirup-99 opened this issue Feb 10, 2021 · 5 comments · May be fixed by #6331
Assignees
Labels
dev-setup 🛠️ scope: documentation Any issue that relates to documentation edits, updates, improvements

Comments

@Abhirup-99
Copy link

I was setting up backend but found the documentation link for postgres docker image is broken.
What would be the way forward?

@Abhirup-99
Copy link
Author

@willemarcel can you help with this one.

@dakotabenjamin dakotabenjamin added the containerization issues that relate to containers infrastructure label Oct 17, 2022
@eternaltyro
Copy link
Contributor

@Abhirup-99 can you elaborate ? Where did you see the link to the documentation?

@eternaltyro eternaltyro self-assigned this Apr 14, 2023
@tsmock
Copy link
Contributor

tsmock commented Apr 27, 2023

I have also seen this link. After a bit of investigation, the Dockerfile was essentially

# This was `FROM mdillon/postgis` -- see removal commit for original
FROM postgis/postgis:latest

ENV POSTGRES_USER hottm
ENV POSTGRES_PASSWORD hottm
ENV POSTGRES_DB tasking-manager

It was removed in 91ba9d4.

As for where references to the missing Dockerfile are located, see https://github.com/hotosm/tasking-manager/blob/develop/docs-old/setup-development.md#build--run-the-postgis-dockerfile and https://github.com/hotosm/tasking-manager/blob/develop/docs/developers/development-setup.md#build--run-the-postgis-dockerfile .

We could probably replace it with docker run --env POSTGRES_USER=hottm --env POSTGRES_PASSWORD=hottm --env POSTGRES_DB=tasking-manager --publish 5432:5432 postgis/postgis:latest. Someone should double check that -- I tested with podman, but it should work with docker.

@ramyaragupathy
Copy link
Member

@spwoodcock - does your PR on separating swagger in docker fixes this? Can you please verify?

@spwoodcock
Copy link
Member

No it's unrelated, but this issue can be solved with a small docs update.

I personally don't think we need such comprehensive documentation for how to set up a standalone postgres container.
That's outside the scope of TM.

We do this by default in the development docker compose config.
If the user wants to change the default config to their spec with TM inside containers, but also linking to a separate database in containers too, I think they will know how to do this anyway.

@ramyaragupathy ramyaragupathy added scope: documentation Any issue that relates to documentation edits, updates, improvements dev-setup 🛠️ and removed containerization issues that relate to containers infrastructure labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-setup 🛠️ scope: documentation Any issue that relates to documentation edits, updates, improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants