Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize API calls and Redesign More Filter section of Explore projects #6325

Merged
merged 27 commits into from May 8, 2024
Merged

Optimize API calls and Redesign More Filter section of Explore projects #6325

merged 27 commits into from May 8, 2024

Conversation

spnayan
Copy link
Contributor

@spnayan spnayan commented Apr 10, 2024 •
edited by royallsilwallz

What type of PR is this?

  • 🍕 Feature
  • 🐛 Bug Fix

Related Issue

Describe this PR

This PR enhance the design of More Filter and restrict the API call on every filter option change

Screenshots

Before
image

After
image

Additional Context

Continued from #5932

mtalhabaig3 and others added 15 commits June 21, 2023 17:20
@mtalhabaig3
made the main page static and enabled scrolling in the filters component
036167b
@mtalhabaig3
Solved the height issue of filters menu
88441ea
@mtalhabaig3
Merge branch 'hotosm:develop' into feature/5844/menu/height
b18a98e
@mtalhabaig3
minor changes
fde0541
@mtalhabaig3
added dependency array
7625f96
@mtalhabaig3
remove the css for hiding scroll bar
f211ea0
@mtalhabaig3
Merge branch 'hotosm:develop' into feature/5844/menu/height
a68367f
@mtalhabaig3
Merge branch 'hotosm:develop' into feature/5844/menu/height
66073a6
@mtalhabaig3
Made dropdowns fixed and hide scroll bar
41d270c
@mtalhabaig3
removed comments
e2b332a
@mtalhabaig3
Merge branch 'hotosm:develop' into feature/5844/menu/height
585d461
@mtalhabaig3
Merge branch 'hotosm:develop' into feature/5844/menu/height
c120198
@mtalhabaig3
solved the front end test error
8611239
@mtalhabaig3
removed comments
5dc659c
@spnayan
Merge branch 'develop' of github.com:hotosm/tasking-manager into enha…
0ff9686 
…ncement/projects-more-filter
@royallsilwallz royallsilwallz changed the title Enhancement/projects more filter Optimize API calls and redesign More Filter section of Explore projects Apr 17, 2024
@royallsilwallz royallsilwallz mentioned this pull request Apr 17, 2024
Closed
@royallsilwallz royallsilwallz changed the title Optimize API calls and redesign More Filter section of Explore projects Optimize API calls and Redesign More Filter section of Explore projects Apr 17, 2024
@varun2948
Copy link
Contributor

@royallsilwallz @spnayan why there is so many commits from mtalhabaig3 in your PR ?

@royallsilwallz
Copy link
Contributor

@varun2948 we've continued the feature/issue from this PR which he had already partially solved.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@royallsilwallz royallsilwallz added type: enhancement Improving an existing functionality good first issue Issues that welcome contributions labels May 3, 2024
@ramyaragupathy ramyaragupathy added status: testing Does it really work or is it pretending to work? upcoming release 🔜 labels May 8, 2024
@ramyaragupathy ramyaragupathy added this to the v4.7.3 milestone May 8, 2024
@ramyaragupathy ramyaragupathy merged commit 90805b8 into hotosm:develop May 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royallsilwallz royallsilwallz royallsilwallz approved these changes

@varun2948 varun2948 Awaiting requested review from varun2948

Assignees
No one assigned
Labels
good first issue Issues that welcome contributions scope: frontend status: testing Does it really work or is it pretending to work? type: enhancement Improving an existing functionality upcoming release 🔜
Projects
None yet
Milestone
upcoming release
5 participants
@spnayan @varun2948 @royallsilwallz @ramyaragupathy @mtalhabaig3