Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to validate a specific task, I am able to validate other tasks in the same project #6320

Open
Patrik-Br opened this issue Apr 7, 2024 · 10 comments

Comments

@Patrik-Br
Copy link

Describe the bug
I am unable to mark a specific task as validated (https://tasks.hotosm.org/projects/15834/tasks/?search=1133), keeps getting the "An error occured while submitting your task." pop up error. I am able to validate other tasks in this project but not this one. anthaas noticed this behaviour on this task yesterday. Today I tested and I am having the same result. Neither me or him worked on this task before.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://tasks.hotosm.org/projects/15834/tasks/?search=1133
  2. Lock the task 1133 for validation
  3. Submit task as validated
  4. See the error

Expected behavior
Be able to validate the task since I can validate other tasks in the same project.

Screenshots
Here is a screen record of how it looks: https://sendspark.com/share/kx6dm2z4odqnwgaz
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Vivaldi
  • Version TM v4.7.1

Additional context
As you can see in the video I tried to refresh my cache using Ctrl+Shift+R shortcut, didn't helped. In the history of the task I can see that the task was marked as more mapping needed in the past, so someone was able to invalidate it before, I haven't tried to invalidate it, just to see if that would work....

@martien-176
Copy link

Tested and have the same result.

I added a screenshot with Inspector report showing a 500 error.

  • Windows 10
  • browser Firefox

TM-error500

@anthaas
Copy link

anthaas commented Apr 16, 2024

This specific task is still corrupted and I'm still not able to submit validation.

@anthaas
Copy link

anthaas commented Apr 17, 2024

Another task to be validated after this bug is fixed. https://tasks.hotosm.org/projects/16303/tasks/?search=831

@manjitapandey
Copy link

I tried to reproduce the issue on local server by replicating the tasks history similar to this but On repeating the same task history too, I was unable to reproduce this issue.
cc: @ramyaragupathy , @kaditya97

@manjitapandey
Copy link

Another task to be validated after this bug is fixed. https://tasks.hotosm.org/projects/16303/tasks/?search=831

I can't test on this task since this project has been already archived.

@ramyaragupathy
Copy link
Member

could be related #6198 cc @kaditya97 @prabinoid @manjitapandey

@anthaas
Copy link

anthaas commented May 7, 2024

https://tasks.hotosm.org/projects/15834/tasks/?search=1133 another task that cannot be validated over and over again.

@ramyaragupathy
Copy link
Member

@prabinoid - can you please post your initial findings here? cc @kaditya97 @manjitapandey

@prabinoid
Copy link

prabinoid commented May 10, 2024

unlock after validation The function seems to be encountering an error where it expects to receive either one or none object in return from the task invalidation history table, but it's receiving two or more objects instead. This discrepancy is causing the function to fail in its validation process.
Screenshot 2024-05-15 at 12 11 36
These are the projects and tasks id with multiple tasks invalidation history entries which are somehow not closed and led to the one or none error while trying to validate the tasks.
Digging deeper on this discrepancy.

@ramyaragupathy
Copy link
Member

Thanks for capturing the information here @prabinoid. It is good to see have a handy list of projects that are affected by this behaviour.

Next actions here:

  • Ramya to coordinate a time with DK and Prabin to remove duplicates from the database. This is a short term fix to remove the blockers from the validation workflow
  • Prabin to investigate and document the steps captured in the database for an invalidation workflow. A task could be invalidated at multiple levels - directly after mapping or after successful validation. It is important the flow in each of the workflow and how it is captured in the backend.

cc @manjitapandey @kaditya97 @dakotabenjamin @prabinoid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

7 participants