Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing Task Lock Extension Duration in Action Text Column #6014

Open
Aadesh-Baral opened this issue Aug 3, 2023 · 1 comment · May be fixed by #6046
Open

[BUG] Missing Task Lock Extension Duration in Action Text Column #6014

Aadesh-Baral opened this issue Aug 3, 2023 · 1 comment · May be fixed by #6046

Comments

@Aadesh-Baral
Copy link
Contributor

Currently, our system stores an "action period" in the action_text column to track the duration of a user's task lock for mapping or validating. However, we have identified an issue with the implementation of the task lock extension feature.

The problem lies in the fact that we are not saving the information about how long the task was extended for. As a result, the action_text column remains empty when the task is in the "EXTENDED_FOR_MAPPING" status.

Here's an example of the issue:

ID Task ID User ID Status Action Text Timestamp Project ID
1735 11 6 LOCKED_FOR_MAPPING 00:01:11.887191 2023-08-03 10:14:32.310950 13526430
1736 11 6 EXTENDED_FOR_MAPPING None 2023-08-03 10:15:44.211045 13526430
1739 11 6 STATE_CHANGE MAPPED 2023-08-03 10:21:48.759124 13526430

As you can see, when the task status changes to "EXTENDED_FOR_MAPPING," there is no duration information provided in the action_text column, unlike when the status is "LOCKED_FOR_MAPPING."

This missing data is crucial for tracking the total duration of task locks accurately, especially when a task is extended multiple times.

Proposed Solution:
To resolve this issue, we need to update our system to include the duration of the task lock extension in the action_text column when the status is "EXTENDED_FOR_MAPPING."

  1. When a task lock is extended, calculate the duration of the extension.
  2. Ensure that the duration is properly updated each time the task lock is extended.

Steps to Reproduce:

  1. Lock a task for mapping/validation.
  2. Observe that the action_text column records the lock duration.
  3. Extend the task lock before its expiry.
  4. Unlock the task.
  5. Check the action_text column for the extended task; notice that the duration of the extension is not recorded.
@ramyaragupathy
Copy link
Member

  • when a task is extended for mapping/validation a new entry is created in task history
  • now if a user unlocks such a task without a state change, then the original entry for extension should be updated with duration
  • if a user unlocks such a task with a state change, the original entry for extension should be updated with duration. Also, a new entry is created for state change
  • if the extended task is auto unlocked, then update the original entry for extension with duration. Change the status from extension → auto unlock

cc @Aadesh-Baral @HelNershingThapa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants